Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extraction of korlibs-crypto #2072

Merged
merged 11 commits into from
Dec 28, 2023
Merged

Extraction of korlibs-crypto #2072

merged 11 commits into from
Dec 28, 2023

Conversation

InsanusMokrassar
Copy link
Contributor

@InsanusMokrassar InsanusMokrassar commented Dec 19, 2023 •
edited by soywiz
Loading

Some work ok #2040

@soywiz
Copy link
Member

soywiz commented Dec 19, 2023

Some work on #2040

@soywiz
Copy link
Member

soywiz commented Dec 19, 2023 •
edited
Loading

Looking at CI, math will likely require require depending on korlibs-memory (or require copying the arraycopy functions as internal)

@soywiz
Copy link
Member

soywiz commented Dec 19, 2023

To reduce the scope of the PR, could you consider doing a PR first splitting just korlibs-crypto? Then in a separate PR -memory could be splitted, and then math.

@InsanusMokrassar
Copy link
Contributor Author

Looking at CI, math will likely require require depending on korlibs-memory (or require copying the arraycopy functions as internal)

Yes, looks like it

@InsanusMokrassar InsanusMokrassar changed the title Extraction of math, memory and crypto parts Extraction of crypto Dec 27, 2023
soywiz
soywiz reviewed Dec 28, 2023
View reviewed changes
Copy link
Member

@soywiz soywiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. Can you have a look?

korlibs-crypto/build.gradle.kts Outdated Show resolved Hide resolved
korlibs-crypto/src/korlibs/memory/InternalCryptoArrays.kt Outdated Show resolved Hide resolved
@InsanusMokrassar
Copy link
Contributor Author

Minor things. Can you have a look?

Sure, will fix it asap

@soywiz soywiz merged commit cc5c2f3 into korlibs:main Dec 28, 2023
9 checks passed
@soywiz
Copy link
Member

soywiz commented Dec 28, 2023

Awesome! Thank you very much

@soywiz soywiz changed the title Extraction of crypto Extraction of korlibs-crypto Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soywiz soywiz soywiz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InsanusMokrassar @soywiz